Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boban/suspense #1886

Closed
wants to merge 43 commits into from
Closed

Boban/suspense #1886

wants to merge 43 commits into from

Conversation

BobanL
Copy link
Collaborator

@BobanL BobanL commented May 22, 2024 •
edited
Loading

PULL REQUEST

General Summary

  • Use "use client" only where necessary, like when we are using browser and interactivity specific functionality. This allows us to default to server side rendering which increase performance.

Explanation of most of the changes.

  • Install jsdom to handle the TableToJson functionality on the server.
  • Install dompurify to clean any potential misconfigured HTML that was passed to us in miscellaneous notes. Since this section is now rendered on the server there are warnings about how invalid HTML is being used and it looked incorrect.
    image (this is fixed with dompurify, just wanted to show the example with it).
  • Fix build to include static assets
  • Fix start to call the standalone server.js that is generated
  • Utilize error.tsx and loading.tsx that are built in to show error and loading states.
  • Move formatTablesToJson to its own file since it should only be used for server side rendering with the use of jsdom.
  • Move metrics into a new component that returns an empty div. This seemed to be the best place to put
  • Remove api calls to fetch data and instead use server actions

Additional Information

Performance on Main:
image
Performance now:
image

React-uswds shows a warning. This change did not introduce this
image

Occasionally, a warning will appear that aria-describedby did not match between the server and the client.
image

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

BobanL added 30 commits May 13, 2024 09:38
@BobanL
update build and start to use standalone
e2af816
@BobanL
use search params as an import to ecr viewer page
9bedd53
@BobanL
Add error and loading pages
bba2cc7
@BobanL
add missing keys
4f9c922
@BobanL
pull out ecr viewer components into separate file
1eec39d
@BobanL
Merge branch 'main' into boban/suspense
f31f43a
@BobanL
Merge branch 'main' into boban/suspense
4e54418
@BobanL
add main landmark
1810436
@BobanL
check dom parser to ensure it is on client component.
b8b30f9
@BobanL
load mappings from loadYamlConfig rather than response of fetch
e823a56
@BobanL
Revert "load mappings from loadYamlConfig rather than response of fetch"
db7816a 
This reverts commit e823a56.
@BobanL
Revert "check dom parser to ensure it is on client component."
7ec10f2 
This reverts commit b8b30f9.
@BobanL
load from yaml config and throw error for not found bundle
20cbee8
@BobanL
revert fhir path mappings to get from api
cf48c40
@BobanL
GET data from server function rather than from api call
5b15f30
@BobanL
Merge branch 'main' into boban/suspense
26f16fc
@BobanL
update EcrViewer page to have h1
07a20dc
@BobanL
Merge branch 'main' into boban/suspense
08d3957
@BobanL
set tooltips as use client
0966546
@BobanL
Merge branch 'main' into boban/suspense
ad1afb9
@BobanL
Make sidenav and expand/collapse buttons "use client"
7276bf5
@BobanL
install jsdom (domparser for node) and dom purify to ensure that misc…
4657cb2 
… notes is valid html
@BobanL
ensure valid html for evaluateClincialData
e98e834
@BobanL
use client on data display
e81f1c3
@BobanL
move tests to appropriate places
8650a33
@BobanL
upgrade testing library react to ensure the same version of @testing-…
fd2c399 
…library/dom is installed
@BobanL
Merge branch 'boban/refactor-evaluatetable-x2' into boban/suspense
69921ef
@BobanL
fix import path for loadYamlConfig
03a1c08
@BobanL
Use a map in Evaluate Table to deterrmine which function to call
16f0a1c
@BobanL
pull out format table to json to own function
fe87867
@BobanL BobanL closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akasper akasper Awaiting requested review from akasper akasper will be requested when the pull request is marked ready for review akasper is a code owner

@angelathe angelathe Awaiting requested review from angelathe angelathe will be requested when the pull request is marked ready for review angelathe is a code owner

@austin-hall-skylight austin-hall-skylight Awaiting requested review from austin-hall-skylight austin-hall-skylight will be requested when the pull request is marked ready for review austin-hall-skylight is a code owner

@gordonfarrell gordonfarrell Awaiting requested review from gordonfarrell gordonfarrell will be requested when the pull request is marked ready for review gordonfarrell is a code owner

@JNygaard-Skylight JNygaard-Skylight Awaiting requested review from JNygaard-Skylight JNygaard-Skylight will be requested when the pull request is marked ready for review JNygaard-Skylight is a code owner

@lina-roth lina-roth Awaiting requested review from lina-roth lina-roth will be requested when the pull request is marked ready for review lina-roth is a code owner

@mcmcgrath13 mcmcgrath13 Awaiting requested review from mcmcgrath13 mcmcgrath13 will be requested when the pull request is marked ready for review mcmcgrath13 is a code owner

@robertmitchellv robertmitchellv Awaiting requested review from robertmitchellv robertmitchellv will be requested when the pull request is marked ready for review robertmitchellv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BobanL